search

mihaifm / HIBPOfflineCheck

Keepass plugin that performs offline and online checks against HaveIBeenPwned passwords
Other
317 stars 17 forks source link

Updated readme instructions and language. #50

Closed cristianst85 closed 1 year ago

cristianst85 commented 1 year ago

Instructions within the README were outdated; the latest version of the password list is v8 (as of December 2021), and the recommended method of downloading the file also changed (as of May 2022).

The suggestion of putting a massive file in the KeePass installation directory does not seem very good to me, so I removed it. And instead, I've added to the Configuration section a note that when Offline mode is selected, the Pwned passwords file must be set. Also, I moved the Configuration section before the Usage section, which seems more natural.

Also, there are some other minor style edits that I've made.

cristianst85 commented 1 year ago

I've updated the README again. I don't like the GetDefaultFileName behavior since there are too many assumptions made there, but I am not gonna change that now.

mihaifm commented 1 year ago

Nice, I actually wasn't aware of the new download method, thanks for that. Indeed the readme probably needs some work, I'll merge this and make some tweaks later.