search

mihaimaruseac / hindent

Haskell pretty printer
Other
561 stars 113 forks source link

Support GHC 9.10.* #904

Closed toku-sa-n closed 2 months ago

toku-sa-n commented 5 months ago

Description of the PR

Fixes: #890

Checklist

mihaimaruseac commented 5 months ago

I'm thinking of doing just one more release with GHC 8 then dropping it. Would that help for this?

toku-sa-n commented 5 months ago

I'm thinking of doing just one more release with GHC 8 then dropping it. Would that help for this?

Unfortunately, no. Adding support for a new GHC version is cumbersome with or without keeping support for older GHCs. Sorry for being late, but I'll complete this PR within a week.

mihaimaruseac commented 5 months ago

Oh, no, no worries about being late. I didn't add a comment to say you're late on this, take as much time as you need. I'm really happy you're working on this, I just got some time to look at the repo this weekend as it is a long one.

toku-sa-n commented 5 months ago

Ah, sorry! Actually, I wasn't hurt, and I didn't mean to hurt you. I always appreciate your review and comments. For the comment, I understand that you just asked a question and didn't have any other intention.

mihaimaruseac commented 5 months ago

No worries about this at all, it's all good :) I really like seeing your work on this!

toku-sa-n commented 2 months ago

So late, and so huge diff, but at least the code now compiles and passes tests with GHC 9.10. I plan to submit clean-up PRs later.

toku-sa-n commented 2 months ago

Thanks for the merge! Could you create a new release? A few changes are not released yet, and this might be a good timing for it.

mihaimaruseac commented 2 months ago

Sure, I'll do it tomorrow first thing. Thanks for the reminder!

toku-sa-n commented 2 months ago

Thanks for the release!