search

mihaiolteanu / vuiet

The music player and explorer for Emacs
https://mihaiolteanu.me/vuiet
GNU General Public License v3.0
278 stars 15 forks source link

Display top albums on artist info buffer #40

Closed firmart closed 3 years ago

firmart commented 3 years ago

Fix #39. I added the custom variable vuiet-artist-albums-limit. I don't know if it makes much sense. If it does, there are three other calls of lastfm-artist-get-top-albums which should be called with :limit vuiet-artist-albums-limit.

Anyway, the docstring and the README should be update accordingly.

firmart commented 3 years ago

Here are the three functions calling lastfm-artist-get-top-albums.

  1. vuiet-album-info
  2. vuiet-album-info-search
  3. vuiet-play-album

I think it would make sense to not set a limit at all to all of them (i.e. don't restrict the search space of albums to merely 10 albums). Otherwise, how could I play an album I can't find ? This being said, it's still relevant to set a limit on the artist info buffer.

firmart commented 3 years ago

BTW, I added playable album links, but one might want to see album info before play it. We can maybe provide another link next to the playable one to see album info.

mihaiolteanu commented 3 years ago

I've considered adding such a feature when I first implemented vuiet. The only thing that it adds is additional last.fm calls which leads to a slower load and display time for the info buffer.

On one side, adding the albums would improve the usefulness, on the other, it increases the response times so it lowers the functionality of the player. Nobody wants to wait and stare at a blank screen.

So I'm not sure about this one. I would leave it open though, if any other ideas come up.

firmart commented 3 years ago

You're right. Maybe we can make it customizable and defaults to a low value ? So far I customize those values to displays up to 1.000 tracks and 100 albums in the artist info buffer. It is instant in my side.

mihaiolteanu commented 3 years ago

It is instant in my side.

Are you sure? The requests to last.fm are buffered, so for stuff you've already called last.fm, it should be instant. But try some new artist, or restart your session.

So far I customize those values to displays up to 1.000 tracks and 100 albums in the artist info buffer It is actually the call to last.fm that takes a lot of time, relatively speaking, not the actual displaying of the info.

If I am proven wrong, there is no reason to add this, of course.

firmart commented 3 years ago

I retried, maybe I exaggerated a bit for "instant", but it takes at most 2s. I find it bearable in my side.

mihaiolteanu commented 3 years ago

No go due to added display time (extra last.fm call needed) during which emacs would just hang.