search

mihaiolteanu / vuiet

The music player and explorer for Emacs
https://mihaiolteanu.me/vuiet
GNU General Public License v3.0
278 stars 15 forks source link

Feature request: Info buffer: back navigation #55

Closed firmart closed 3 years ago

firmart commented 3 years ago

At present, we can navigate through tag and artist on artist/tag info buffer. But we cannot navigate backward through the history.

mihaiolteanu commented 3 years ago

I think the artist info buffer (and the like) open up a new info buffer when you click an element from it. Closing the new info buffer still keeps the old one open.

firmart commented 3 years ago

Yeah, so I'm thinking of keeping a stack to store e.g. searched artists and add a function or local keybinding to come back the last info buffer. If the old buffer is not killed, simply switch to it. Otherwise, refetch the info buffer.

Mihai Olteanu notifications@github.com writes:

I think the artist info buffer (and the like) open up a new info buffer when you click an element from it. Closing the new info buffer still keeps the old one open.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/mihaiolteanu/vuiet/issues/55#issuecomment-774953329

mihaiolteanu commented 3 years ago

I think this is overkill. Every new feature complicates the implementation as well. It's nice and fun when you implement it, not so when you come back to it later or something is broken.

firmart commented 3 years ago

Well, in this particular case I do not agree. In contrast to other PRs which look complicated, and they are, this one is just a matter of a few lines. But it's your package after all. You decide.

Mihai Olteanu notifications@github.com writes:

I think this is overkill. Every new feature complicates the implementation as well. It's nice and fun when you implement it, not so when you come back to it later or something is broken.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/mihaiolteanu/vuiet/issues/55#issuecomment-775168020