mihaiolteanu / vuiet

The music player and explorer for Emacs
https://mihaiolteanu.me/vuiet
GNU General Public License v3.0
278 stars 15 forks source link

Bug: `vuiet-info-playing-track-album' fails when current track has no album #56

Closed firmart closed 2 years ago

firmart commented 3 years ago

Similar to bug #53 due to lastfm.el inconsistency.

Because

(lastfm-track-get-info artist song)

returns the list (album playcount listeners) if there is an album, and (playcount listeners) if there is not.

Solution: either fix it upstream in lastfm.el (e.g. return (nil playcount listeners)) or type check the result of lastfm-track-get-info. This issue may occur in several places (e.g. vuiet-play-playing-track-album).

mihaiolteanu commented 3 years ago

either fix it upstream in lastfm.el (e.g. return (nil playcount listeners))

Definitely the preferred solution. Please let an example, also.

mihaiolteanu commented 2 years ago

Closed: solved with #53