search

mihaip / dex-method-counts

Command-line tool to count per-package methods in Android .dex files
Apache License 2.0
2.6k stars 376 forks source link

Adding functionality to resolve symlinks #11

Closed who closed 9 years ago

who commented 9 years ago

This fixes https://github.com/mihaip/dex-method-counts/issues/10

niedzielski commented 9 years ago

This is a one-liner with readlink. Isn't it a reasonable dependency?

who commented 9 years ago

@niedzielski It can only be a one-liner on Linux, as OS X does not support readlink -f.

My PR is tested on OS X (Yosemite) and Linux (Ubuntu 14.04).

niedzielski commented 9 years ago

Is it unreasonable to expect users to install Hombrew or another package manager?

On Wed, May 6, 2015 at 2:58 PM, Andrew B notifications@github.com wrote:

@niedzielski https://github.com/niedzielski It can only be a one-liner on Linux, as Max OSX does not support readlink -f.

My PR is tested on OS X (Yosemite) and Linux (Ubuntu 14.04).

— Reply to this email directly or view it on GitHub https://github.com/mihaip/dex-method-counts/pull/11#issuecomment-99608260 .

who commented 9 years ago

@niedzielski

Is it unreasonable to expect users to install Hombrew or another package manager?

I personally don't think its unreasonable, but not everyone uses Homebrew. I wanted to present a stand-alone solution.

Here's how we could do it with Homebrew:

brew install coreutils

and then

greadlink -f

mihaip commented 9 years ago

Thanks!