mihaip / infinite-mac

A classic Mac loaded with everything you'd want
https://infinitemac.org
Apache License 2.0
1.2k stars 73 forks source link

The Emscripten toolchain shouldn't live in an image pulled from a registry #178

Closed seishun closed 1 year ago

seishun commented 1 year ago

The important bits of the Docker image used for building the emulators come from a parent image that gets pulled from GitHub Packages. That makes it complicated to make changes to the toolchain, e.g. to try a different version of Emscripten.

Perhaps it would make sense to merge https://github.com/mihaip/emscripten-docker into the Dockerfile here?

mihaip commented 1 year ago

Thanks for reminding me about this -- I had been meaning to switch to using emsdk to install the toolchain. Should be done now.