mihaip / infinite-mac

A classic Mac loaded with everything you'd want
https://infinitemac.org
Apache License 2.0
1.12k stars 66 forks source link

Rename Outside World's surrounding folder in generated ZIP file please? #307

Closed that-ben closed 3 months ago

that-ben commented 3 months ago

I have a request: Would it be possible for IM not to name the folder in the uploaded ZIP file in Outside World the exact same name as the file? Perhaps prepend "_" to the folder name would be nice or something like that? It makes it frustrating to extract the contents, because you cannot move the file out of the surrounding folder that IM is creating without renaming one of them manually first.

mihaip commented 3 months ago

I kind of like the name being clean. I use it to create archives for the Infinite HD library (see .zips in https://github.com/mihaip/infinite-mac/tree/main/Library/Control%20Panels%20%26%20Extensions and other directories). No one else has mentioned this as being a problem.

If you'd like to change it in the version of Infinite Mac that you host, you can tweak the naming logic at https://github.com/mihaip/infinite-mac/blob/77f043a19bdf20e6f071ad798806d36290f9a850/src/emulator/emulator-ui-extractor.ts#L206

that-ben commented 3 months ago

One thing you could have added is the date/time at the end of the ZIP file name. This way it would even add value to the process, since if one exports a file, then modifies it and re-exports it again, then by having the date/time appended to the end of the ZIP file name, it would instantly be clear which version of the file it is.