import-cd-roms fails on missing resource (with proposed fix)

When running import-cd-roms, if a CD-ROM resource is missing, the entire setup aborts and doesn't allow generation of the JSON manifest, which doesn't allow me to finish setup.

The script fails with the error
Failed to download https://archive.org/download/fam-cd/FAM_CD.ISO

The traceback leads to a failed http request initiated by import-cd-roms.py

Indeed, the CD image is not available at the above URL.

Local commit hash:

commit 718d1a0f15c9e67178e69db8f29f6d739f942c2b (origin/main, origin/HEAD, main)
Author: Mihai Parparita <mihai@persistent.info>
Date:   Sun Mar 10 18:15:36 2024 -0700

    Allowlist another external disk image domain

Proposed diff for import-cd-roms.py:

def main():
    shutil.rmtree(paths.COVERS_DIR, ignore_errors=True)
    os.mkdir(paths.COVERS_DIR)

    input_manifests = load_manifests()
    output_manifests = {}
    for folder_path, input_manifest in input_manifests:
        try:
            output_manifest = get_output_manifest(input_manifest)
            output_manifests[folder_path] = output_manifest
        except Exception:
            continue

# ...

I recommend a simple try-catch where you initiate the request, however I'm sure you can do it in a more clean way than I did.
The above allowed me to get the project up and running.

Sorry for sitting on this fix for so long.
Really appreciate your work!

mihaip / infinite-mac

import-cd-roms fails on missing resource (with proposed fix) #313