search

mihaip / infinite-mac

A classic Mac loaded with everything you'd want
https://infinitemac.org
Apache License 2.0
1.18k stars 72 forks source link

[Feature request] Fixed integer scaling #35

Open parkerlreed opened 2 years ago

parkerlreed commented 2 years ago

Using on the tablet (Tab S7+ on Android 12) it doesn't lock to any integer scale, so trying to zoom in and out to get it to look good is very tricky. Full screen tries but is still off by a little.

parkerlreed commented 2 years ago

Video showing the scaling (and an issue where in full screen, the pointer location is very offset)

https://user-images.githubusercontent.com/841440/161343814-74d2187d-9b6a-4fd1-a89b-5dee3f77595d.mp4

mihaip commented 2 years ago

I recently made some fixes for scaling (https://github.com/mihaip/infinite-mac/commit/9027c562d30f2542955ee72ad1e194e49f7ea79d) and touch/mouse event handling (https://github.com/mihaip/infinite-mac/commit/3788b5deee47aea588081a7e6b1e64e711e431f1), is it any better for you? I don't have access to an Android tablet, but FWIW I'm not seeing these issues on an iPad.

parkerlreed commented 2 years ago

Looking at the system 7 site, it still seems to be wonky.

Along with the full screen input still being very offset.

20220406_115946

parkerlreed commented 2 years ago

I set a breakpoint for isFullscreen and I get these as the variables

Could the uneven scale be what's throwing this off?

heightScale: 1.5583333333333333
isFullScreen: true
widthScale: 1.8675

image

mihaip commented 2 years ago

We choose whichever is smaller, but we don't round (prioritizing filling up the screen).