search

mihaip / react-closure-compiler

Tooling to teach Closure Compiler about React
Apache License 2.0
100 stars 14 forks source link

Update Closure Compiler to v20190325 #33

Closed arv closed 5 years ago

arv commented 5 years ago

This is not yet working

arv commented 5 years ago 
$ ant test
Buildfile: /src/react-closure-compiler/build.xml

compile:
    [javac] /src/react-closure-compiler/build.xml:27: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds

testcompile:
    [javac] /src/react-closure-compiler/build.xml:63: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds

jar:

test:
    [junit] Testsuite: info.persistent.react.jscomp.PropTypesExtractorTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.697 sec
    [junit]
    [junit] Testcase: testConvertPropTypeToTypeNode took 0.611 sec
    [junit] Testsuite: info.persistent.react.jscomp.ReactCompilerPassTest
    [junit] Tests run: 35, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 18.457 sec
    [junit]
    [junit] Testcase: testReactDOMServer took 2.359 sec
    [junit] Testcase: testMethodDefaultParameters took 0.153 sec
    [junit] Testcase: testChildren took 0.211 sec
    [junit] Testcase: testMethodJsDoc took 0.389 sec
    [junit] Testcase: testNamespacedComponent took 0.135 sec
    [junit] Testcase: testState took 0.847 sec
    [junit] Testcase: testPureRenderMixin took 0.131 sec
    [junit] Testcase: testInstanceMethods took 0.515 sec
    [junit] Testcase: testPropTypesComponentMethods took 0.331 sec
    [junit] Testcase: testUnusedComponent took 0.104 sec
    [junit] Testcase: testCreateElementValidation took 0.02 sec
    [junit] Testcase: testReactDOM took 0.515 sec
    [junit] Testcase: testPropTypes took 1.618 sec
    [junit] Testcase: testMixinsValidation took 0.058 sec
    [junit] Testcase: testThisUsage took 0.094 sec
    [junit] Testcase: testEs6ModulesScoping took 0.263 sec
    [junit] Testcase: testPropTypesMixins took 0.559 sec
    [junit] Testcase: testNoRenameReactApi took 0.74 sec
    [junit] Testcase: testPropTypesTypeChecking took 5.053 sec
    [junit] Testcase: testCreateElementCasting took 0.29 sec
    [junit] Testcase: testCreateClassValidation took 0.046 sec
    [junit] Testcase: testElementTypedef took 0.159 sec
    [junit] Testcase: testCreateMixinValidation took 0.047 sec
    [junit] Testcase: testExport took 0.018 sec
    [junit]     Caused an ERROR
    [junit] null
    [junit] java.lang.NullPointerException
    [junit]     at com.google.javascript.jscomp.JSDocInfoPrinter.print(JSDocInfoPrinter.java:79)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.maybeAddTypeAnnotation(TypedCodeGenerator.java:81)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:56)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:662)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:57)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:662)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:57)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:104)
    [junit]     at com.google.javascript.jscomp.CodePrinter.toSource(CodePrinter.java:878)
    [junit]     at com.google.javascript.jscomp.CodePrinter.access$300(CodePrinter.java:40)
    [junit]     at com.google.javascript.jscomp.CodePrinter$Builder.build(CodePrinter.java:813)
    [junit]     at info.persistent.jscomp.Debug.toTypeAnnotatedSource(Debug.java:19)
    [junit]     at info.persistent.react.jscomp.ReactCompilerPass.process(ReactCompilerPass.java:147)
    [junit]     at com.google.javascript.jscomp.Compiler.process(Compiler.java:1037)
    [junit]     at com.google.javascript.jscomp.Compiler.runCustomPasses(Compiler.java:1070)
    [junit]     at com.google.javascript.jscomp.Compiler.check(Compiler.java:1014)
    [junit]     at com.google.javascript.jscomp.Compiler.performChecksAndTranspilation(Compiler.java:829)
    [junit]     at com.google.javascript.jscomp.Compiler.lambda$stage1Passes$0(Compiler.java:759)
    [junit]     at com.google.javascript.jscomp.CompilerExecutor.runInCompilerThread(CompilerExecutor.java:129)
    [junit]     at com.google.javascript.jscomp.Compiler.runInCompilerThread(Compiler.java:817)
    [junit]     at com.google.javascript.jscomp.Compiler.stage1Passes(Compiler.java:757)
    [junit]     at com.google.javascript.jscomp.Compiler.compile(Compiler.java:675)
    [junit]     at info.persistent.react.jscomp.ReactCompilerPassTest.test(ReactCompilerPassTest.java:1785)
    [junit]     at info.persistent.react.jscomp.ReactCompilerPassTest.test(ReactCompilerPassTest.java:1705)
    [junit]     at info.persistent.react.jscomp.ReactCompilerPassTest.testExport(ReactCompilerPassTest.java:1045)
    [junit]
    [junit] Testcase: testFields took 0.147 sec
    [junit] Testcase: testTypeValidation took 1.247 sec
    [junit] Testcase: testMixins took 0.717 sec
    [junit] Testcase: testEs6Modules took 0.309 sec
    [junit] Testcase: testMinimalComponent took 0.071 sec
    [junit] Testcase: testOptimizeForSize took 0.263 sec
    [junit] Testcase: testInterfaces took 0.117 sec
    [junit] Testcase: testPropsSpreadInlining took 0.019 sec
    [junit]     Caused an ERROR
    [junit] null
    [junit] java.lang.NullPointerException
    [junit]     at com.google.javascript.jscomp.JSDocInfoPrinter.print(JSDocInfoPrinter.java:79)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.maybeAddTypeAnnotation(TypedCodeGenerator.java:81)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:56)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:662)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:57)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:104)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.addFunction(CodeGenerator.java:1417)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:403)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:57)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.addExpr(CodeGenerator.java:1609)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.addStringKey(CodeGenerator.java:1688)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:1009)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:57)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:104)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:1036)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:57)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.addExpr(CodeGenerator.java:1609)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.addList(CodeGenerator.java:1645)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.addList(CodeGenerator.java:1633)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:863)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:57)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:104)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:1140)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:57)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.addExpr(CodeGenerator.java:1609)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:286)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:57)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.addExpr(CodeGenerator.java:1609)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.addList(CodeGenerator.java:1645)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:233)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:57)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:662)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:57)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:662)
    [junit]     at com.google.javascript.jscomp.TypedCodeGenerator.add(TypedCodeGenerator.java:57)
    [junit]     at com.google.javascript.jscomp.CodeGenerator.add(CodeGenerator.java:104)
    [junit]     at com.google.javascript.jscomp.CodePrinter.toSource(CodePrinter.java:878)
    [junit]     at com.google.javascript.jscomp.CodePrinter.access$300(CodePrinter.java:40)
    [junit]     at com.google.javascript.jscomp.CodePrinter$Builder.build(CodePrinter.java:813)
    [junit]     at info.persistent.jscomp.Debug.toTypeAnnotatedSource(Debug.java:19)
    [junit]     at info.persistent.react.jscomp.ReactCompilerPass.process(ReactCompilerPass.java:147)
    [junit]     at com.google.javascript.jscomp.Compiler.process(Compiler.java:1037)
    [junit]     at com.google.javascript.jscomp.Compiler.runCustomPasses(Compiler.java:1070)
    [junit]     at com.google.javascript.jscomp.Compiler.check(Compiler.java:1014)
    [junit]     at com.google.javascript.jscomp.Compiler.performChecksAndTranspilation(Compiler.java:829)
    [junit]     at com.google.javascript.jscomp.Compiler.lambda$stage1Passes$0(Compiler.java:759)
    [junit]     at com.google.javascript.jscomp.CompilerExecutor.runInCompilerThread(CompilerExecutor.java:129)
    [junit]     at com.google.javascript.jscomp.Compiler.runInCompilerThread(Compiler.java:817)
    [junit]     at com.google.javascript.jscomp.Compiler.stage1Passes(Compiler.java:757)
    [junit]     at com.google.javascript.jscomp.Compiler.compile(Compiler.java:675)
    [junit]     at info.persistent.react.jscomp.ReactCompilerPassTest.test(ReactCompilerPassTest.java:1785)
    [junit]     at info.persistent.react.jscomp.ReactCompilerPassTest.test(ReactCompilerPassTest.java:1705)
    [junit]     at info.persistent.react.jscomp.ReactCompilerPassTest.testPropsSpreadInlining(ReactCompilerPassTest.java:1689)
    [junit]
    [junit] Testcase: testStatics took 0.226 sec
    [junit] Testcase: testEs6ModulesMixins took 0.524 sec
    [junit] Testcase: testMixinsRepeatedMethods took 0.081 sec
    [junit] Test info.persistent.react.jscomp.ReactCompilerPassTest FAILED
    [junit] Testsuite: info.persistent.react.jscomp.ReactWarningsGuardTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.066 sec
    [junit]
    [junit] Testcase: testPropsValidator took 1.017 sec

BUILD FAILED
/src/react-closure-compiler/build.xml:102: if=hasFailingTests

Total time: 22 seconds

earvidsson at earvidsson-ltm1 in /src/react-closure-compiler on upgrade-to-20190325
$
arv commented 5 years ago

The JSDocInfo is null. Not sure how to track that down. I'm looking further but do you have any hints?

arv commented 5 years ago

All tests pass. PTAL

arv commented 5 years ago

Replaced by #35