search

mihaip / react-closure-compiler

Tooling to teach Closure Compiler about React
Apache License 2.0
100 stars 14 forks source link

Add @implements to mixin classes too #58

Closed arv closed 5 years ago

arv commented 5 years ago

If a mixin class has a mixin then the mixin class should have an @implements for the interface backing the mixin. For example:

class MixinB extends React.Component {
  /**
   * @param {string} s
   * @override
   */
  method(s) {}
}
ReactSupport.declareMixin(MixinB);
ReactSupport.mixin(MixinB, MixinA);

Should end up with:

/** @implements {MixinAInterface} */
class MixinB extends React.Component {
arv commented 5 years ago

Passes now

TBR

mihaip commented 5 years ago

LGTM