search

miharekar / visualizer

A visualizer for .shot files
https://visualizer.coffee/
MIT License
97 stars 11 forks source link

Can not download a (paginated) list of my shots #106

Closed Chris-B73 closed 3 months ago

Chris-B73 commented 3 months ago

Describe the bug Downloading a (paginated) list of my shots as described in the API does not work.

To Reproduce curl --location 'https://visualizer.coffee/api/shots/?page=1&items=10' -u "my_username:my_password" > Page1.json

Page1.json contains this line:

{"error":"Could not paginate"}

Desktop (please complete the following information): macOS 14.5, zsh

Additional context When I tried it the first time one week ago, it worked as expected.

miharekar commented 3 months ago

God damn Pagy! 😡 They are obsessed with changing their API for no reason whatsoever. 😒

Expect fix to be deployed in the next couple of minutes.

Chris-B73 commented 3 months ago

Thanks for being so fast! It works again 😃.

ddnexus commented 2 months ago

God damn Pagy! 😡 They are obsessed with changing their API for no reason whatsoever. 😒

@miharekar maybe you are right about the obsession: we like to add new features! That may cause confusion with the API... which requires cleanups overtime.

That's the reason why mayor versions (complying with semantic versioning) are expected to introduce breaking changes, that we document thoroughly in the "Breaking Changes" section of the "CHANGELOG" docs.

I am wondering why your test suite didn't catch it before your release.

BTW... in order to avoid the risk of breaking your app at each bundle update you should use pessimistic version constraints in your Gemfile (as we suggest it in the "Versioning" section of our "README" and in the Quick Start example).