miharekar
commented
2 years ago There are many problems with this.
The main one is that the vast majority of shots don't have this data. Of the 526.997 currently in the database, 5.997 have TDS data, and 5.871 have EY data. That's ~1,1%. And even when they have this data, it's all over the place. Some people use decimal points, some decimal commas, and some people enter some sort of text.
This is the reason both of these are stored as text, not numbers. And that brings us to the following problem: it's impossible to make these comparisons in SQL since I'd have to interpret the data first. That means loading all the shots in memory, then interpreting the data inside, then doing the filtering, and then returning all that comply.
This translates to a lot of additional memory capacity I can not afford with the current Heroku plan. I plan to move to a different provider soon, but that's because I'm close to hitting the limits already without this additional load.
Another big problem is that this would need to be a range search (like enjoyment), and not a text search (like everything else). This means I'd need two sliders for both, so four new sliders.
All that would make the filtering UI much bigger and filtering backend vastly more complex, and I'm sorry, but I don't see this being worth it for ~1% of the shots 🤷♂️
gte534j
Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
please add the ability to search for Drink TDS (Total Dissolved Solids) and Drink EY (Extraction Yield)
Describe the solution you'd like A clear and concise description of what you want to happen.
A filter option to refine your search.
Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
Additional context Add any other context or screenshots about the feature request here.