search

miharekar / visualizer

A visualizer for .shot files
https://visualizer.coffee/
MIT License
97 stars 11 forks source link

Breaking change in Turbo #86

Closed NickGeek closed 1 year ago

NickGeek commented 1 year ago

Describe the bug Turo introduced a breaking change in 1.4.0 that requires an explicit tag for links within turbo frames (to indicate if it should do a full navigation or load in the frame). This is visible in the "recent" tab on visualizer when clicking the "view" link.

One fix for this would be to add data-turbo-action="advance" target="_top" to the turbo-frame that contains the links which are expected to do a page navigation.

To Reproduce Steps to reproduce the behavior:

  1. Go to /shots
  2. Click on "recents"
  3. Click on "view"
  4. "Not Found" shows up with an error from turbo in the console instead of being navigated to the search page.

Expected behavior The page should navigate to the search results

miharekar commented 1 year ago

Thanks for this!

I saw it didn't work on my phone a couple of days ago, but then forgot to look into it 🙈