miharekar / visualizer

A visualizer for .shot files
https://visualizer.coffee/
MIT License
97 stars 11 forks source link

Brew beverage quantity is not correctly displayed #93

Closed HorseCalledGolgotha closed 1 year ago

HorseCalledGolgotha commented 1 year ago

While importing the brew session from beanconqueror Visualizer displays the beans stock quantity instead of the brew beverage quantity.

Steps to reproduce the behavior:

  1. Export brew session from beanconqueror
  2. Import to visualizer.coffee
  3. Go to the "Your Shots" tab
  4. beans stock quantity is displayed with extraction elapsed time

Expected behavior: Display tag "brew_beverage_quantity" value

Screenshots

Screenshot 2023-06-30 alle 14 10 21 Screenshot 2023-06-30 alle 14 12 07

Desktop :

Smartphone :

miharekar commented 1 year ago

Please provide a sample export file. Feel free to email it to me

HorseCalledGolgotha commented 1 year ago

Hi Miha, here the export 16753486-7422-4760-a4a2-7b7b88b4d8f7_visualizer.json.zip

miharekar commented 1 year ago

The issue was that most of the test files I had, did not have brew_beverage_quantity filled in, so that's why I didn't know that was the correct one 😅

Anyway, the importer was fixed now, and it should be fine for imports from now on.

HorseCalledGolgotha commented 1 year ago

Perfect, thanks!