mihdan / cyr2lat

Converts Cyrillic characters in post, page and term slugs to Latin characters. Useful for creating human-readable URLs.
https://wordpress.org/plugins/cyr2lat/
GNU General Public License v2.0
36 stars 10 forks source link

Bulgarian conversion table (bg_BG) fixes of specific letters. #97

Closed atanasantonov closed 3 years ago

atanasantonov commented 3 years ago

Hello,

First of all thank you for this awesome plugin!

As native Bulgarian I allow myself to propose some fixes in Bulgarian letters. Reference here: [https://2cyr.com/?7]

Letters Й, Ц and Щ needs fixes. Letters "I" and "i" are not part of Bulgarian language and are useless.

As note letters below "I" and "i" are part of the old Bulgarian and probably are not used these days.

2021.05.13 Update: After consultation with #translators at wpbulgaria.slack.com the best option is old letters to stay as is.

All the best, Atanas

MrGKanev commented 3 years ago

@atanasantonov if we have to be honest don't we need to remove everything after "Я"? All these characters are part of the old Bulgarian alfabet: 'Ѣ' => 'YE', 'ѣ' => 'ye', 'Ѫ' => 'О', 'ѫ' => 'о', 'Ѳ' => 'FH', 'ѳ' => 'fh', 'Ѵ' => 'YH', 'ѵ' => 'yh',

atanasantonov commented 3 years ago

@MrGKanev Probably yes. As seen from the Wikipedia article you shared the last of them "was used until the orthographic reform of 1945". But maybe they can stay just in case somebody can and want to write in Old Bulgarian. I don't know what is better... I'll talk with the WordPress translators team in Bulgaria.

atanasantonov commented 3 years ago

Dear @MrGKanev I've a quick chat in #translators at wpbulgaria.slack.com about the old letters. We've agreed that the best option is old letters to stay as is and if somebody use them to be possible to be converted. A traditional Bulgarian saying is "They don't need bread nor water".

kagg-design commented 3 years ago

Thank you for the PR.

We use, however, ISO9 standard.

You can modify the table in the admin or by the hook ctl_table.

atanasantonov commented 3 years ago

Thanks @kagg-design I get it.