Add 'no-debug', 'no-skip', 'no-only' rules

miherlosev / eslint-plugin-testcafe

MIT License

15 stars 7 forks source link

Add 'no-debug', 'no-skip', 'no-only' rules #8

Open benmonro opened 4 years ago

benmonro commented 4 years ago

it seems there are no recent commits on this Repo. i would be happy to take it over and add some new rules (like no-debug, no-focus-test, no-skip-test etc). I'm the author & maintainer of eslint-plugin-jest-dom and actively contribute to other eslint plugin repos. I love testcafe but this plugin needs more rules!

benmonro commented 4 years ago

@miherlosev

miherlosev commented 4 years ago

Hi @benmonro,

It would be great if you help us improve this plugin. Let's approve a list of rules for adding. I suggest the following rules:

no-debug - restricts the use of the .debug() action in tests;
no-skip - restricts the use of the .skip hook for tests or fixtures;
no-only - restricts the use of the .only hook for tests or fixtures.

Would you please clarify the logic of the no-focus-test rule? It's not quite clear what it should do.

benmonro commented 4 years ago

Yeah that's the same as no-only. Jest calls those focused tests and the jest lint rule is called no focused tests. They are fine for debugging locally but you shouldn't commit them

miherlosev commented 4 years ago

We will use the terminology of TestCafe. So, the resulting list of rules is no-debug, no-skip, no-only. These are the most important rules. The PR from you is greatly appreciated.

benmonro commented 4 years ago

Yeah that's fine.