mihirkatare / DeepMEM

Deep Learning Implementations for Sustainable Matrix Element Method Calculations [ IRIS-HEP Fellowship ]
Apache License 2.0
2 stars 0 forks source link

feat: Update model architecture and multiprocessing #16

Closed mihirkatare closed 2 years ago

mihirkatare commented 2 years ago
matthewfeickert commented 2 years ago

@mihirkatare Do we need to keep the contents of post/ in version control? They're all binaries, so unless there is a necessity to have them be versioned I'd suggest instead attaching them as artifacts to a GitHub release (which for the time being would mean copying out elsewhere to keep).

mihirkatare commented 2 years ago

@mihirkatare Do we need to keep the contents of post/ in version control? They're all binaries, so unless there is a necessity to have them be versioned I'd suggest instead attaching them as artifacts to a GitHub release (which for the time being would mean copying out elsewhere to keep).

We mention that the library will be pip-installable. Does that include the pre-trained models? i.e the .pth binaries. Otherwise i'll get rid of the post/directory

mihirkatare commented 2 years ago

Okay the binaries have been removed from main

matthewfeickert commented 2 years ago

Does that include the pre-trained models? i.e the .pth binaries. Otherwise i'll get rid of the post/directory

Yeah, I'd distribute those separately, or rather, make them available separately. I'll go back into the commit history and sweep these into another branch that we can just keep around as a vestigial holder for the time being.

Once I do that I'll merge this in.

matthewfeickert commented 2 years ago

@mihirkatare for reference those binaries now have been cherry-picked to the branch backup/post-model-binaries.