mihirlad55 / polybar-spotify-module

A collection of lightweight programs for use with a Polybar Spotify Module
GNU General Public License v3.0
140 stars 9 forks source link

IPC Updates & Minor Bugfixes #38

Closed corigne closed 11 months ago

corigne commented 11 months ago

Primary Changes:

Minor Changes:

Bug-fixes:

k1ng440 commented 11 months ago

Hey @corigne,

Thank you for this pull request. I know it's not my business but changes of spotify-listener.c is massive due to your formatting which adds unnecessary complexity to code review.

corigne commented 11 months ago

I didn't actually add much. Due to shifting things around the diff looks larger than it is, unfortunately. I could try to clean that up but I'm not sure where to start without rewriting history. I could create another branch and then append my changes rather than putting them in arbitrary locations.

However if the maintainer and others believe it would be better served to excise the two functions I wrote into a separate file then I can do that.

Moving the two functions outside of the file could also unnecessarily break up relevant code in favor of reducing the size of the diff in my opinion that's not a great tradeoff.

Happy to try to make the diff less confusing when I have time again, though if that makes life easier for the maintainers.

Tl;dr I'll see what I can do about the diff size if it's a problem.

corigne commented 11 months ago

Closing. Will reopen when I've reduced the diff as much as possible for clarity.