mihirsamdarshi
commented
1 year ago Hi @yangshoulai, thanks for the question.
If I understand correctly, you’re asking about this bit of code
No, the method will not block in the next loop. The method read_buf_bytes() checks how many bytes (n) were read from the stream. If n is 0, this basically translates to there being no more data to read on the stream. Let's say BUFFER_SIZE is 4KB and your file is also 4KB. This does not mean the last read() will block, because the operating system typically knows the file size ahead of the read operations, thus it will read 4KB and then report EOF (end of file), i.e., it will return 0 to the read() on the next loop indicating there is nothing left to read, and hence that will not block. If it's 0, it's usually because the file has already finished (EOF has been reached), and subsequent read() calls will therefore return 0 immediately. The behavior of the code is essentially relying on the read() system call's behavior on an EOF.
As such, the function will run through the loop until it reads the entire stream and once that's done, the next stream.read call will immediately return 0, this returns false from read_buf_bytes() and the loop breaks. Therefore, read_stream() won't block even if the read stream size is exactly equal to BUFFER_SIZE.
yangshoulai
TheBlindM
In async-ssh2-lite/src/main.js line 49, if the read stream size exactly equal BUFFER_SIZE, method read_buf_bytes will return true, will current method block in next loop? I am a newer to Rust and I am searching for ssh local port forwarding, Thank you very much if you could answer my question。