search

mihirsoni / odfe-monitor-cli

Manage your Alerting monitors
Apache License 2.0
34 stars 22 forks source link

Create multiple files for monitors rather than one big monitors file + Go Modules for dep management #13

Open kushagharahi opened 3 years ago

kushagharahi commented 3 years ago

This is a breaking change from the current implementation. One big monitors yaml will not work anymore.

Sorry about the reverts. I assume it'll be squash and merged anyway.

RaJiska commented 3 years ago

Any news on this matter ? We would also be interested in many smaller files rather than a big one with every monitors.

kushagharahi commented 3 years ago

Any news on this matter ? We would also be interested in many smaller files rather than a big one with every monitors.

As it stands unfortunately I don’t have time to implement backwards compatibility in this PR like the author wants. I plan on getting to it... sometime in the future. At my job we use the fork on my profile for individual files per monitor

RaJiska commented 3 years ago

Any news on this matter ? We would also be interested in many smaller files rather than a big one with every monitors.

As it stands unfortunately I don’t have time to implement backwards compatibility in this PR like the author wants. I plan on getting to it... sometime in the future. At my job we use the fork on my profile for individual files per monitor

Ah, what a shame. Thank you for your PR nonetheless, we'll also use it to implement the same feature on our side.