search

mihirsoni / react-native-android-speech

This simple React Native module for Android Text To Speech functionality.
https://www.npmjs.com/package/react-native-android-speech
48 stars 14 forks source link

Handle if TTS service is not installaed #2

Closed vincenzoiacovone closed 8 years ago

vincenzoiacovone commented 8 years ago

With this change user can handle if TTS service is not installed on the device. If is not installed, raise an exception in metod "speak"

mihirsoni commented 8 years ago

@vincenzoiacovone Could you explain a use case in lil more detail ?

vincenzoiacovone commented 8 years ago

If Google TTS service is not installed on device (this package: https://play.google.com/store/apps/details?id=com.google.android.tts ) actual source doesn't handle the exception. If you try to play a TTS, nothing happens. With this code edit, if you play a TTS and you don't have service installed, an exception will be raise

[http://lh3.ggpht.com/yrkQ_bDsgS0eFnJRsqxzPDdRNNHE9-dK1eZYNoN3ryDl9V9foQwZgZaTZwiYUfv2jnGI=w300]https://play.google.com/store/apps/details?id=com.google.android.tts

Google Text-to-speech - Android Apps on Google Playhttps://play.google.com/store/apps/details?id=com.google.android.tts play.google.com Google Text-to-speech powers applications to read the text on your screen aloud. For example, it can be used by: • Google Play Books to “Read Aloud ...

Da: Mihir Soni notifications@github.com Inviato: venerdì 22 luglio 2016 12.14.26 A: mihirsoni/react-native-android-speech Cc: vincenzoiacovone; Mention Oggetto: Re: [mihirsoni/react-native-android-speech] Handle if TTS service is not installaed (#2)

@vincenzoiacovonehttps://github.com/vincenzoiacovone Could you explain a use case in lil more detail ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mihirsoni/react-native-android-speech/pull/2#issuecomment-234507968, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARvD84V2eVBRJCV2PmDD7839No5q20igks5qYJgCgaJpZM4JSm9l.

mihirsoni commented 8 years ago

@vincenzoiacovone Okay make sense , I will do the test and close merge this.

Thank you for your PR.