search

mihneadb / node-directory-tree

Convert a directory tree to a JS object.
MIT License
523 stars 106 forks source link

Cannot find name 'IObj' #122

Closed rankida closed 1 year ago

rankida commented 1 year ago

Hello 👋

It appears a recent change has broken the typings for this module.

I am getting the following error which I think is related to https://github.com/mihneadb/node-directory-tree/pull/121 where the IObj interface was removed but is still used at index.d.ts#L37.

I will try to open a PR today, but I wanted to raise this issue now.

Thanks for the effort and great work maintaining an OSS package takes 🙇

mihneadb commented 1 year ago

Hey, oops, you're right. Thanks a lot for the help! Is there any way to somehow cover things like these while testing?

rankida commented 1 year ago

Hi @mihneadb , I have added an example of how to test this in my PR here.

Feel free to use or throw it away.

mihneadb commented 1 year ago

Makes sense, merging, thanks!