Test failed on Windows - Githubissues

mihneadb / node-directory-tree

Convert a directory tree to a JS object.

MIT License

523 stars 106 forks source link

Open rattanakchea opened 6 years ago

rattanakchea commented 6 years ago

On my Windows, the npm run test failed, because file size does not match.

mihneadb commented 6 years ago

@rattanakchea do you think you can make a cross-platform fix for it? Thanks!

rattanakchea commented 6 years ago

Since file sizes on Windows, Mac or other OS can very slightly. It is no one test fit all.

My suggestion would be remove file size when testing? Any other suggestion?

mihneadb commented 6 years ago

Sounds good. It should still test that size is present, just not check its value, I guess.