search

mihneadb / node-directory-tree

Convert a directory tree to a JS object.
MIT License
523 stars 106 forks source link

Default attributes only "name", "path" and "children" #93

Closed Momijiichigo closed 3 years ago

Momijiichigo commented 3 years ago

I changed the code a little bit to make default attributes only "name", "path" and "children". issue thread

mihneadb commented 3 years ago

Thanks for this! Can you please merge the latest master so GIthub checks are included? It seems tests are not passing.

Momijiichigo commented 3 years ago

Hi! I included Github checks! Please check the test script where I changed, to produce the same result as before (i.e. I added attributes: ['size','type','extension'] option in the test code.)

loshchini commented 3 years ago

Hi! The release with this fix ruined semver 😢

mihneadb commented 3 years ago

Sorry to hear that. You mean 2.4.0?

loshchini commented 3 years ago

Yeah, specifically, removing from default attributes "size", "extension" and "type" was breaking changes. Just paying attention :)

mihneadb commented 3 years ago

You're right, it should have turned into 3.0.0 since it is a breaking change. Sorry about that, will make a release. Thanks for notifying!

mihneadb commented 3 years ago

Deprecated 2.4.0, can't unpublish it now. Published 3.0.0. Thanks again.

loshchini commented 3 years ago

Thanks for reaction!