search

mihnita / ansi-econsole

Eclipse plugin that understands ANSI escape sequences to color the Eclipse console output.
http://www.mihai-nita.net/java/
Other
90 stars 25 forks source link

changed the default behavior of the copy action to remove escapes #20

Closed martinlippert closed 8 years ago

martinlippert commented 8 years ago

I slightly changed the behavior of the default copy action to that escape characters get removed before the text is copied into the clipboard. This makes it a lo easier to deal with the console, especially when working on apps and doing copy/paste for errors, log output, exceptions, stack traces, etc.

I also changed the behavior of the "copy plain text" icon in the toolbar to always include the escape sequences, so that you can use that action if you need the exact escape characters (which should not be the case that often).

The default copy action takes the settings into account. So if you have the Ansi Console enabled, it removes the escape sequences, otherwise not.

Hope this works for you and can be incorporated into a new version soon.

Thanks!!!

martinlippert commented 8 years ago

btw, this works for the keyboard shortcut actions (ctrl-c) as well as the global "copy" menu entry. It doesn't work yet for the "copy" action from the context menu. Will submit an additional pull request once I figured out how to do that.

martinlippert commented 8 years ago

did you have the chance to take a look at this yet? if there are any concerns, let me know. I am happy to change/update the pull request if you need things differently.

mihnita commented 8 years ago

Sorry, I did not manage to take a look at it, I was under a combination of flu + deadlines :-) I'll try to move things this week-end. Mihai

mihnita commented 8 years ago

Sorry, I had a lot of things in my plate lately, both at home and work, and I did not have time for it (not so much accepting a merge as doing a release)

Bot I tried to get into it, and noticed the header with a copyright and a license. And, sorry to say, this is something I have not time to consider. Earlier in the project I have spent some time on deciding on a license, to decide if I add headers to files or not, to clear any possible issues with my employer at the time.

And now this is the only file copyright header. And an Eclipse Public License v1, while the whole project is under Apache License v2.0. I don't know if they are compatible or not, I don't know if I want to mix them even if they are.

I am not saying that what you did is wrong, and can't even say "if you do this instead it's OK"

It is just that I don't have the energy and time to think and decide about legal crap now. It drains me more than any codding decision. And way-way more than plain codding.

So I will not take it, not for now. It is late, I am tired, and just don't want to deal with it. I am sorry :-( I will think about it. And take it. Or implement from scratch. I just don't know right now...

martinlippert commented 8 years ago

I have to admit that I didn't take care of the license of the project too much either. Those are the standard license headers that I use for my daily work. I am sure we can find a solution for this, if you are still interested in this. I really would love to get this contribution into the project (instead of forking it). I am fine with contributing the code under the Apache 2 license. Would that help?