search

mihnita / ansi-econsole

Eclipse plugin that understands ANSI escape sequences to color the Eclipse console output.
http://www.mihai-nita.net/java/
Other
90 stars 25 forks source link

Provide source bundle for updatesite #58

Closed laeubi closed 3 years ago

laeubi commented 3 years ago

currently the update-site only contains the compiled sources, it would be nice if source bundles are also provided to make development easier.

mihnita commented 3 years ago

Sorry, I am not very familiar with that. I know that there are some configuration stuff in Eclipse about the sources of the plugin.

But I think that everything is in GitHub. If you clone the project the sources of the plugin are in AnsiConsole folder, the feature description in AnsiConFeature, and the sources of the update site are in the AnsiConSite folder.

Is that what you are looking for, or is there something else? Where can I read about it?

Thanks, M.

laeubi commented 3 years ago

As you are using Tycho, it allows to generate the most stuff for this so you don't need to do much: there are some examples here: https://wiki.eclipse.org/Tycho/Reference_Card#Source_Bundles https://wiki.eclipse.org/Tycho/Reference_Card#Source_Features

mihnita commented 3 years ago

Ah, I see.

Thing is, I'm not using Tycho. I've tried a (long) while ago, but it required a relatively new version of Eclipse, if I remember well.

Right now I still support Neon. I keep a version around, and old JDK 8, just for this :-) So I prepare the release from the Eclipse GUI (Neon + JDK 8). Then test on newer Eclipse versions, then Win / macOS / Linux, before pushing it out. Then git tag the repository it and push it (if you run git tag you see the exact release points)

So what you see in this repo is all I have.

Should I take another look at Tycho? Maybe... but I don't release often enough to be a pain :-)

laeubi commented 3 years ago

Is there any rationale in supporting ancient eclipse versions? anyways you should be able to build with tycho targeting old eclipse releases/java8 latest tycho just need java11 to run. Especially the pomless build was improved making using tycho a lot easier.

But I think if you export from the IDE there should also be an option to export the sources:

grafik

mihnita commented 3 years ago

Is there any rationale in supporting ancient eclipse versions?

I've checked the HTTP request logs since Dec 1, 2020 (last 2 months) About 6% of the requests still come from "ancient" Eclipse versions (mars, oxygen, neon, photon) I'm not using any fancy new APIs that are not supported on older versions. So why intentionally break these people (about 300)?

anyways you should be able to build with tycho targeting old eclipse releases/java8 latest tycho just need java11 to run.

That's another one :-) 29% of the requests come from Java 8. So a lot of people are still on that.

Yes, in theory you can generate JDK 8 class files with Java 11. But it is possible to call methods and use classes from the Java 11 runtime, and there is no good validation for that. The .class files will still be generated "for Java 8", but fail to run. I've seen this in a different project.

See here, better explained: https://bugs.openjdk.java.net/browse/JDK-8058150

To prevent that I can run another tool that checks for that. But that's just adding more complexity. It is just easier to compile with 8.

Again, I'm not releasing often enough to be a pain.

Generating sources from GUI: I'm looking into that.

I am not using the flow that goes through the UI you captured. I am still doing a "build", not an "export".

The first version of this plugin was in 2012. Things changed a lot since then (tycho was at 0.14 or so), Eclipse did things a certain way. I've figured out how to do it then, and didn't changed. It's still working, so why bother...

Will dig more, probably over the week-end. Meantime I have a full time job, and the sources are available, if someone needs them :-)

laeubi commented 3 years ago

No need to hurry, you can configure tycho to use a java-8 jdk for compilation, verification just in case your bored of exporting it from the UI :-)

mihnita commented 3 years ago

Everything should be in.

I don't think I would release just for this. But I'll check what other fixes / enhancements I did since releasing 1.4.3 and see if it is work a release. Anyway, next time it will be there, unless you have some urgent need.

Thanks a lot, Mihai

mihnita commented 3 years ago

Fixed. Will be in the next release.

laeubi commented 3 years ago

Nothing urgent, I'm just reworking the eclipse-cucumber plugin and it can benefit from a color console but at them moment everything works fine!

mihnita commented 3 years ago

Can you do that without sources?

Would it help if I re-release the older version (the one that is already out), with sources? (I can make it happen by "messing up" with the XMLs files by hand :-)

laeubi commented 3 years ago

Sure sources are optional, if its too much hassle at the moment, feel free to delay it to some later point in time (e.g. if you are doing a release anyways).

mihnita commented 3 years ago

I think I am done with what I wanted to do for a new release:

In order to fix issue #45 I had to migrate from actions (deprecated) to commands, which is something I wanted to do for a long time. But it forces me into giving up control on the enabled / disabled colors. Eclipse controls that... and I don't like the result. But it is what it is...

I intend to test a bit more and release over the week-end.

If you want to play with it a bit early you can install from here (version 1.4.4.202102040736): https://www.mihai-nita.net/eclipse_test

mihnita commented 3 years ago

Released.