search

mihnsen / ui-carousel

A simple, lightweight module for carousel in your AngularJS app, Inspired from slick carousel.
http://mihnsen.github.io/ui-carousel/
MIT License
77 stars 67 forks source link

angular 1.6 and ui-carousel doesn't work #1

Closed evan4 closed 7 years ago

evan4 commented 7 years ago

Here is my repo https://github.com/evan4/carousel There ara 2 version of angular - 1.5.8 and 1.6 By default i use 1.5.8 - It is bower_components/angular/angular.min.js and carousel works fine But I try to replace angular 1.5.8 with 1.6 (bower_components/angular/angular.js) all photos disapeared. And I see only arrows. I have a question. Do I need use angular 1.6 or I have to stick with 1.5.8 ?

mihnsen commented 7 years ago

Hi Evan, I will take a look soon, I will update this carousel to support all angular 1 version. Keep me up to date,

See you in few hours, Minh

On Tue, Dec 20, 2016 at 3:21 PM, evan notifications@github.com wrote:

Here is my repo https://github.com/evan4/carousel http://url There ara 2 version of angular - 1.5.8 and 1.6 By default i use 1.5.8 - It is bower_components/angular/angular.min.js and carousel works fine But I try to replace angular 1.5.8 with 1.6 all photos disapeared. And I see only arrows. I have a question. Do I need use angular 1.6 or I have to stick with 1.5.8 ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mihnsen/ui-carousel/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AJTxch4xpKCt5U1Du0zgoYP8hAdM-7Cwks5rJ4_zgaJpZM4LRkwK .

--

NGUYEN TIEN MINH Software Engineer at Ownego Inc Email: minhnt.hut@gmail.com Skype: minhnt.hut Phone: 0911556248

Everything you can't imagine !

mihnsen commented 7 years ago

It seems we have to migrate angular 1.5 to 1.6 with some changes: https://docs.angularjs.org/guide/migration#migrating-from-1-5-to-1-6

evan4 commented 7 years ago

Re: [mihnsen/ui-carousel] angular 1.6 and ui-carousel doesn't work (#1)

Здравствуйте, Minh.

Вы писали 20 декабря 2016 г., 15:31:43:

It seems we have to migrate angular 1.5 to 1.6 with some changes: https://docs.angularjs.org/guide/migration#migrating-from-1-5-to-1-6 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Another libraries works fine like ui-bootstrap

-- С уважением, Иван                          mailto:evan4mc@gmail.com

mihnsen commented 7 years ago

@evan4 Fixed on 96ae129