search

miho / JCSG

Java implementation of BSP based CSG (Constructive Solid Geometry)
Other
177 stars 52 forks source link

Text3D Depends on a specific version of JCSG #31

Closed madhephaestus closed 7 years ago

madhephaestus commented 7 years ago

JCSG depends on extfxyz, which in turn dependes on JCSG 0.3.2, causing a dependency loop and importing out of date classes. This breaks downstream implementations.

https://repo1.maven.org/maven2/eu/mihosoft/ext/org/fxyz/extfxyz/0.4/extfxyz-0.4.pom

If they both depend on each other, maybe they should be merged?

miho commented 7 years ago

extfxyz is just a workaround.

If they both depend on each other, maybe they should be merged?

Unfortunately, they are separate projects. I'm not the author of the FXyz library. It just has been published via bintray by the main authors. Maybe you could ask them to split the library. This would break the loop.

madhephaestus commented 7 years ago

I fixed my Implementation of 3d test with no external dependencies. Would you be interested in a PR to replace the underlying system? (i ask because pulling out my code into a clean PR is a bit of work and i would only do it if you are interested in merging it)

This is the class i would use as a sub-system for your Text3d API (i would not be changing your API) https://github.com/NeuronRobotics/JCSG/blob/master/src/main/java/eu/mihosoft/vrl/v3d/TextExtrude.java

madhephaestus commented 7 years ago

If this PR gets merged, i will work from that branch to add the bezier functionality in the same way.