search

miho / MonacoFX

JavaFX editor node based on the powerful Monaco editor that drives VS Code
MIT License
78 stars 25 forks source link

Published artifact adds dependency on JavaFX for Windows #6

Closed jperedadnr closed 4 years ago

jperedadnr commented 4 years ago

When using the library on Mac or Linux, JavaFX 12.0.1-win artifacts are included, which is not convenient.

This happens because the pom has these dependencies:

<dependency>
      <groupId>org.openjfx</groupId>
      <artifactId>javafx-graphics</artifactId>
      <version>12.0.1</version>
      <classifier>win</classifier>
      <scope>runtime</scope>
    </dependency>
...

that include the win classifier.

One way to avoid it is to remove the classifiers from the generated pom (see for instance this). Removing the classifier from the pom is not a problem, once in a given platform Maven will resolve the required classifier.

miho commented 4 years ago

I just verified it. Especially, the jfx-web dependency is quite annoying. Can you create a PR for this? Thanks for letting me know.

jperedadnr commented 4 years ago

Ok, done!