miho / SonoAir

135 stars 6 forks source link

unable to connect with b6.1 / 10.12.3 #21

Open olets opened 7 years ago

olets commented 7 years ago

This is the output I get after letting b6.1 run for about 10 minutes.

Zwei mal Play1 Node 7.4.0

Brauchst du noch einige Information?

>> DEBUG: retryCounter: 0
>> DEBUG: using new discovery method
                                <--- here I opened and closed the Preferences window
>> DEBUG: retryCounter: 0
>> DEBUG: using new discovery method
java.lang.NullPointerException
    at java.lang.String.compareTo(String.java:1155)
    at eu.mihosoft.sonoair.SonoAir.lambda$null$8(SonoAir.java:399)
    at java.util.TimSort.countRunAndMakeAscending(TimSort.java:355)
    at java.util.TimSort.sort(TimSort.java:220)
    at java.util.Arrays.sort(Arrays.java:1512)
    at java.util.ArrayList.sort(ArrayList.java:1454)
    at java.util.Collections.sort(Collections.java:175)
    at eu.mihosoft.sonoair.SonoAir.lambda$rescanAndReRunAirSonos$9(SonoAir.java:398)
    at java.lang.Thread.run(Thread.java:745)
Exception in thread "Thread-7" java.lang.NullPointerException
    at eu.mihosoft.sonoair.SonoAir.lambda$rescanAndReRunAirSonos$9(SonoAir.java:409)
    at java.lang.Thread.run(Thread.java:745)
Exception in thread "cling-6" java.lang.NullPointerException
    at org.tensin.sonos.control.AbstractService.findService(AbstractService.java:101)
    at org.tensin.sonos.control.MediaServerDevice.<init>(MediaServerDevice.java:49)
    at org.tensin.sonos.control.ZonePlayer.<init>(ZonePlayer.java:109)
    at eu.mihosoft.upnp.sonos.ZonePlayer.<init>(ZonePlayer.java:45)
    at eu.mihosoft.upnp.sonos.ZonePlayers$1.remoteDeviceAdded(ZonePlayers.java:50)
    at org.fourthline.cling.registry.RemoteItems$1.run(RemoteItems.java:111)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
stephenjharrington commented 7 years ago

I can confirm also that SonoAir 1.0 Beta 6.1 is unable to detect my 4 (2 in a stereo Group) Sonos systems when I run it, even though I leave it for many minutes. I am also running macOS 10.12.3.

Reverting back to Beta 5.0 restores functionality, although I'd really like to use the the "Minimise On Start" and "Disable "Experimental Build" Warning Dialogue" options that 6.1 brings. Was my main reason for trying it!

I notice also in 6.1 I can't select "old discovery method" in Preferences as it is greyed out. Is this the way it should be?

StephenH

miho commented 7 years ago

Do you know whether you have unnamed devices? The code assumes that all devices have a unique name. And I think, the Sonos App prevents unnamed devices and groups. But when I simulate unnamed devices, I can reproduce the bug. What is your exact setup?

stephenjharrington commented 7 years ago

Hi Michael, may I start by saying how much I appreciate your hard work on this program, and how valuable it is to us all! Much appreciated!

My setup is that I have 2 X Play:5's (Gen 1) in stereo pair, a Play:3 and also a Connect hooked up as an input on my main sound system. All are running wired ethernet with the Sonos wireless turned off.

I don't believe I have any "unnamed devices" but I'm not sure I fully understand what I would see if I did?

Beta 5.0 works perfectly, detects my units reliably within about 20 seconds, although it has other issues of course, hence my trying Beta 6.1 :-) Would love to get it to start minimised and not have the Experimental Build warning dialogue :-)

I've enclosed output from my Sonos Application "About My Sonos System" as a zip file if that helps.

If you want any other diagnostics let me know ... where does the 6.1 debugging output appear within macOS if you turn it on? In console?

Regards,

StephenH

About My Sonos.zip

olets commented 6 years ago

Sorry, missed your reply. My setup is two Play1's in a named group. Let me know if I can answer other questions!