Extension points - Githubissues

miho / VWorkflows

Flow Visualization Library for JavaFX and VRL-Studio

http://vworkflows.mihosoft.eu

Other

296 stars 67 forks source link

Extension points #44

Closed aalmiray closed 8 years ago

aalmiray commented 8 years ago

This PR addresses the following points:

reduce code duplication between FXConnectionSkin and FXNewConnectionSkin by adding a type in between.
expose package private classes as public.
apply license headers to all files

WARNING: The AbstractFXConnectionSkin classes follows the template method pattern to let its subclasses initialize various aspects. This leads to an explicit invocation of the init() method right after the constructor is invoked.

coveralls commented 8 years ago

Coverage increased (+0.3%) to 21.633% when pulling a1e82a5efcbd911c83bba47a0d0a3d724e1275ba on aalmiray:extension-points into e168f531ace3a5640fe9bb72f8fcf06f5c055be7 on miho:master.

miho commented 8 years ago

I'm glad that the duplication between FXConnectionSkin and FXNewConnectionSkin is gone :-) I'll accept the PR (sorry for the delay). Regarding the visibility changes (exposing private API) I'm hoping for actual use cases. Would be cool if you could contribute some of your extension as well.

Andres, thanks for the contribution!

aalmiray commented 8 years ago

thank you 😄 there are other changes needed in the rest of the Skin classes. We'll continue exploring options and send back PRs

miho commented 8 years ago

:+1: