search

miho / VWorkflows

Flow Visualization Library for JavaFX and VRL-Studio
http://vworkflows.mihosoft.eu
Other
294 stars 67 forks source link

Issue #49: Remove gap adjustment from connector position offset #50

Closed cbvms123 closed 8 years ago

cbvms123 commented 8 years ago

This is a quick fix which is least intrusive. In essence the adjustment by (+ connectorWidth / 2) in computeConnectorXValue is undone by several (- connectorShape.getRadius()) adjustments in other parts of the code.

As from reading the code I understand the semantic of this value is the layoutX value, these adjustments should be removed at all.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 17.463% when pulling d8c23da932255ea07107cd8f3bbf8dfd8bf33b21 on cbvms123:issue49 into 02aa42014b169178371f105a97f00c2f6ad9d0fa on miho:master.

miho commented 8 years ago

Thanks for the fix!