search

miho / VWorkflows

Flow Visualization Library for JavaFX and VRL-Studio
http://vworkflows.mihosoft.eu
Other
294 stars 67 forks source link

Refactor for extension #58

Open aalmiray opened 7 years ago

aalmiray commented 7 years ago

WARNING: Big refactor ahead.

Motivation: VWorkflows 0.2.x makes it difficult to extend behavior for third parties as many of the classes expect specific implementations of a particular interface. There are also many places where Java's package private scope is used.

This pull request offers an alternate design. The library already defined most of its core types as interfaces while supplying default implementations. These implementations have been split into two packages: base and impl. The base package may be used as starting point for 3rd parties that would like to write their own custom implementations of the core interfaces. The impl package provide ready-made, default implementations of the core interfaces, in effect they are behavior compatible with version 0.2.x.

Usage of package private access has been reduced to a minimum. Classes have been relocated to other packages, grouped by responsibility.

This refactor constitutes a break in binary compatibility

Please review at your earliest convenience. We're open to feedback and discussion on the proposed changes as we understand it may be too big to swallow in one go.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 17.756% when pulling 594d8d245e56e70f864d63c24320c39b27f39716 on aalmiray:factories into 0e1522cd7341397e180b33ae24081e07c649740a on miho:master.

cbvms123 commented 7 years ago

This patch has a dependency to scaledfx 0.4 which is not yet uploaded to central.

miho commented 7 years ago

Huge, indeed :) Since it seems to introduce incompatibilities, I won't merge it right now. But we will meet in a few days anyway and we can certainly find some time for further discussions.