Open ThaUnknown opened 1 month ago
The color issue should be fixed/adjust in Mihon Preview with a Themes/color change (#766). Give Mihon Preview a try or wait for a future Mihon Stable update that contains this change. It shouldn't be blue-grey but it'll be near AMOLED black now (color design choice).
sidenote that's not a navbar
sidenote that's not a navbar
web dev brain goes "navbar on top", was tired as shit when I was writing that, so I had about 1% of my brain capacity to write that sentence, got the message across
@Smol-Ame no this is not fixed on preview either, it becomes grey, not black
@Smol-Ame no this is not fixed on preview either, it becomes grey, not black
Ah whoops, was told later after my response that this is a different thingy, my bad
Could you send a video since the picture isn't quite self explanatory
https://github.com/user-attachments/assets/bda7d99c-0c50-449d-8540-40a6924b01c1
visibly changes color when scrolling, very annoying for under-screen cameras
Please just send the whole video.
there's nothing else to see there, thats just me scrolling up and down, there's no other context
Hmm well I can't reproduce.
https://github.com/user-attachments/assets/c26f0694-a89d-4c56-b0aa-bc2353014848
i'm unwilling to share my library
sorry for multiple comments doing this across devices, here are my appearance settings
notably my library has 100 entries, i dont know how many you tested this on, but there seems to be a minimum distance to be scrolled for this to happen
I can reproduce this on 4 different smartphones on mihon 0.16.5 and even tachi 15.3 on android 11, 12 and 14, even on fresh installs, I find it difficult to believe u can't reproduce this @AntsyLich, if your display is bad and can't produce low dark colors take screenshots and use some color picker tools to compare the colors
I set everything the same and scrolled, my UI is not doing this. It might be related to your specific phone brand
I set everything the same and scrolled, my UI is not doing this. It might be related to your specific phone brand
i have tested and reproduced this on redmagic, google pixel, redmi and motorolla, that's unlikely, even on brand new fresh installs downloaded directly from https://mihon.app/download/
funny enough it doesnt happen on browse tab scrolling [sources, extensions, migrate], but happens on library, updates, history and settings [reader as its the only menu tall enough to reproduce this]
Just fyi we are following the Material design guidelines for Updates, History, Settings etc. so it's intentional. But we are not following the guideline for Library and Browse as they have a category system. Anyway given it's not happening on Browse I can take a look and compare their implementation.
Not having the top app bar background elevated when there are tabs is fully compliant with material guidelines.
This is why for browse and library (when tabs not disabled) the top app bar isn't tinted.
The guideline is under Scrolling content: https://m3.material.io/components/tabs/guidelines
I think the issue is, there's no spec for amoled black theme from material 3, so by implementing that in the first place you stray away from being fully compliant with m3, so I think it becomes more important that "when amoled black is enabled, make it better for amoled phones"
Steps to reproduce
Expected behavior
the top nav bar should stay black
Actual behavior
the top navbar slightly changes color
Crash logs
No response
Mihon version
App version: 0.16.5 (standard, 2a01a2a, 6, 2024-04-09T09:58:14Z) Android version: 14 (SDK 34; build REDMAGICOS9.0.13_NX769J_EEA) Device brand: nubia Device manufacturer: nubia Device name: NX769J (NX769J-EEA) Device model: NX769J WebView: Android System WebView 127.0.6533.23
Android version
14
Device
Redmagic 9
Other details
this is quite annoying with an under screen camera which can't reproduce such dark colors correctly, the usual fix is to use AMOLED black themes, but this weird behavior prevents that from being q fix
Acknowledgements