Saved images with wrong date

Hoodieni commented 3 months ago

Steps to reproduce

Screenshot_20240806_175741_com hihonor photos

When downloading Manga panels the date of the downloaded image changes. Happens in different sources

Expected behavior

It should save with the date of download not a random date.

Actual behavior

The panel gets downloaded on a weird date

Crash logs

No crashing

Mihon version

App version: 0.16.5 (standard, 2a01a2a, 6, 2024-04-09T09:58:14Z)

Android version

Android version: 14 (SDK 34; build ALI-N23 8.0.0.172(C605E1R2P2))

Device

Device brand: HONOR

Other details

Device manufacturer: HONOR Device name: HNALI-Q (ALI-NX3) Device model: ALI-NX3 WebView: Android System WebView 127.0.6533.64

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.5.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Smol-Ame commented 3 months ago

Adding on for context/similarity, #552

Additional info/convo here: https://discord.com/channels/1195734228319617024/1196111629482463422/1270516869895557160

mm12 commented 3 months ago

looking at ReaderViewModel::saveImage I think this might be a problem with the image stream itself - ie, the source of the image has a bad date, and the app is just passing it along.

I found an example from a source and downloaded the image with my browser. This confirms it:

mm12 commented 2 months ago

In other words, this is not the app's fault, unless you want to have it override dates with the current DateTime, which I think would be nice

mihonapp / mihon