Open OdisBy opened 1 month ago
I'd like to work on this issue
Not a Mihon issue since it's fine on the screenshot. Your device has defect.
I agree, it seems to be an issue with the phone's frame. Although it's not a problem with Mihon, can I add a way to allow for this padding? Maybe I could add a configuration option for a bottom margin, and those who need it could enable it? I could set it to something like 4 dp of margin, or perhaps offer a configuration where the user can choose this padding? In that case, it would be available in the Settings.
If you agree, I could open a Feature Request issue and close this one.
@OdisBy I would just change the label.
Other things to check:
Also related, my Pixel 3 has a similar issue where some items are pushed off the screen (including the lock icon on the lock screen), as if they are referencing a screen location wrong.
Anyway, I see this as a potential feature more than a bug, yes
Not a Mihon issue
Technically It is. Mihon didn't handle display cutout insets.
@OdisBy You can disable "show content in cutout area" as a workaround before a proper fix is landed.
Ah that makes sense. Are you working on a fix or I can go ahead?
Ah that makes sense. Are you working on a fix or I can go ahead?
I don't have time now. I can do it later in the week if it's not fixed yet.
I was planning to work on this bug, but since it could impact all users and this would be my first contribution, I prefer to leave it for the AntsyLich and take on something else!
@OdisBy does this issue occur in any other place in the app?
@AntsyLich I just tested the entire application, I didn't find anywhere else with this problem
Steps to reproduce
Expected behavior
Being able to fully see the page number at the bottom of screen as the image below
Screenshot from my device with open chapter
![image](https://github.com/user-attachments/assets/6c97bb1d-562d-4647-bd71-f5ab2c6ccabe)
Actual behavior
On the real device the page number is cut off, and it is not possible to read the numbers. It is hidden by the small edges that the device has. Both in the screenshot and in the emulator the number will appear correctly, so I will attach a photo of my real device with this problem.
Full Picture
![image](https://github.com/user-attachments/assets/a2855082-dd44-46e4-8b09-4760f90b627d)
With zoom on page numbers
![image](https://github.com/user-attachments/assets/9a7ca708-4fb5-4537-8f3b-4b0560639eb4)
Crash logs
No response
Mihon version
0.16.5
Android version
Android 14
Device
Samsung A54
Other details
This issue seems to be related to the edges of the devices. I noticed that when taking a screenshot or mirroring my phone, it appears correctly at the bottom of the screen, but this is not the visible behavior on the actual device. For the same reason, emulating a device will display it correctly.
It won't be possible to fully demonstrate this behavior with screenshots from the devices, so I have attached a photo of my actual device showing this problem in the Actual Behavior section. Additionally, I will attach some related complaints that I found from other users both on Discord and in an Issue here on GitHub.
Issue on Github #526
Message on Support channel (Mihon Discord)
[https://discord.com/channels/1195734228319617024/1196111629482463422/1198382299763445871](https://discord.com/channels/1195734228319617024/1196111629482463422/1198382299763445871) ![image](https://github.com/user-attachments/assets/5182ef86-cfa4-4935-a0e4-62b0a8f3b269)
Acknowledgements