search

mihonapp / mihon

Free and open source manga reader for Android
Apache License 2.0
10.53k stars 482 forks source link

App doesn't restore entries that have errors. #120

Closed THElegend5 closed 2 months ago

THElegend5 commented 10 months ago

Steps to reproduce

  1. Restore a backup which contains errors.
  2. Wait for it to finish restoring.

Expected behavior

You get a notification saying there where errors in the restore.

Actual behavior

You get a notification saying the backup restored successfully.

Crash logs

2024-01-18 01:08:28.309] Why Are You Obsessed With Your Fake Wife? [Official] [Bato.to]: ResultSet returned more than 1 row for chapters.sq:getChapterByUrl
[2024-01-18 01:10:20.189] Diamond in the Rough [Komga]: ResultSet returned more than 1 row for chapters.sq:getChapterByUrl
[2024-01-18 01:43:13.074] Fables [Komga]: ResultSet returned more than 1 row for chapters.sq:getChapterByUrl
[2024-01-18 01:44:04.612] For Each Retweet, Two Straight Girls Who Don't Get Along Will Kiss for One Second - Their First Night [MangaDex]: ResultSet returned more than 1 row for chapters.sq:getChapterByUrl

You have to go app data folder to get the failed restore logs

Mihon version

r6454

Android version

Android 14

Device

Samsung S21 FE

Other details

https://cdn.discordapp.com/attachments/1099009853864812710/1197472596166455296/temp.proto.gz?ex=65bb6442&is=65a8ef42&hm=2207fbd9f20a63f6e6c8b1879dcef13173438953c9e66616a51ee74e91b00430& Example backup file which contains errors only two entries will fail to restore

Also a thing to not is that before new restore logic these entries restored fine but you would get notification saying there were x errors in restore. In versions with new logic there is no indication that these entries fail to restore.

Acknowledgements

MajorTanya commented 10 months ago

This is a duplicate of #27 isn't it

THElegend5 commented 10 months ago

This is a duplicate of #27 isn't it

Might be but their entries seem to be restoring and they seem to also get error along with it, while mine don't restore neither do I get a error message unless I dig into the appdata folder.

DchanN commented 10 months ago

Mine showing the error and can show error list when tap it

Screenshot_20240118-222125357 (1)

MajorTanya commented 10 months ago

Mine showing the error and can show error list when tap it

Screenshot_20240118-222125357 (1)

can you show the error log please, this doesn't help much

DchanN commented 10 months ago

Mine showing the error and can show error list when tap it Screenshot_20240118-222125357 (1)

can you show the error log please, this doesn't help much

error log same with thelegend and from #27 , me just comment mine show the error, because this issue said app doesn't show error

THElegend5 commented 10 months ago

Seems like you can access the errors but there is no indication in the notification that there has been an error unlike earlier versions. old-version.jpg

I think the last time I tried to click it in the new version it somehow failed to bring up an option to open the error file but it does indeed open the error file in the new version even while giving no indication there has been an error.

THElegend5 commented 10 months ago

After a bit more testing and changing a couple of things in my tachiyomi library and backing up restoring mihon now does seem to be mentioning the errors so it not showing there has been errors might be a one of thing or something limited to that backup or simply be that it was there and I didn't see it but the entries are still not being restored so updating the title to reflect that.

Note: These entries are restored in an old version.

AntsyLich commented 2 months ago

647