source search with an empty result won't show Empty screen - Githubissues

mihonapp / mihon

Free and open source manga reader for Android

Apache License 2.0

10.64k stars 489 forks source link

source search with an empty result won't show Empty screen #1456

Closed cuong-tran closed 5 days ago

cuong-tran commented 2 weeks ago

Steps to reproduce

Go to a source's Browse/Latest page
Wait for it to load entries
Hit search, type in some random long string (just to make sure source won't find any thing and would return an empty search result

Expected behavior

After the LoadingScreen showing up, it should show an EmptyScreen with no result

Actual behavior

LoadingScreen won't show (as in #1438)
The screen still showing the entries loaded from Browse/Latest page with a toast saying "No results found"

Crash logs

No response

Mihon version

r6990

Android version

Android 14

Device

AVD

Other details

Caused by commit 2f4bb7cadb0297492cfb21393e75ca276e0539d7

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.17.0.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

cuong-tran commented 5 days ago

Fixed with 9aef08c333397caa4b897514cf76966592d3849c