Dynamic theme is using colors from default theme.

mihonapp / mihon

Free and open source manga reader for Android

Apache License 2.0

9.16k stars 402 forks source link

Dynamic theme is using colors from default theme. #283

Open THElegend5 opened 7 months ago

THElegend5 commented 7 months ago

Steps to reproduce

Select dynamic theme as you theme.

Expected behavior

App uses colors from your wallpaper.

Actual behavior

App is still using the default theme.

Crash logs

No response

Mihon version

r6499

Android version

Android 14

Device

Samsung S21FE

Other details

No response

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.3.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

ShanaNyaa commented 7 months ago

Would like to add, I'm currently having the same issue here

Mihon Version

Stable 0.16.3

Android Version

Android 14

Device

Samsung Galaxy Z Flip 5

afa1425 commented 7 months ago

facing it here too

Mihon Version

Stable 0.16.3

Android Version

Device

Samsung Galaxy Z Fold4

Xori71 commented 7 months ago

Dynamic Theme works fine for me. Provide me with some screenshots, if you could.

afa1425 commented 7 months ago

0.16.3: appearance menu in settings with dynamic theme selected about menu

after downgrading to 0.16.2 (what it should look like): appearance menu in settings with dynamic theme selected about menu

Xori71 commented 7 months ago

0.16.3: appearance menu in settings with dynamic theme selected about menu

after downgrading to 0.16.2: appearance menu in settings with dynamic theme selected about menu

Yeah, works fine for me.

afa1425 commented 7 months ago

what device are you using?

Xori71 commented 7 months ago

what device are you using?

Redmi Note 9 Pro, running an Android 14 custom ROM.

afa1425 commented 7 months ago

could be only affecting samsungs then

mechagomizilla commented 7 months ago

I'm on Samsung (S23 ultra) and I don't have this problem. And yeah, I tried the pre-release version, and it still works.

EDIT: Scratch that, I just tried changing the system-level color palette and Mihon seems to have kept the previous one in cache, because it's not changing.

acszo commented 6 months ago

it's an issue with the newer compose material 3 versions on One UI 6 (and 6.1), but it seems to work fine on older version of One UI like 4 and 5

THElegend5 commented 6 months ago

Seems to be due to a change in implementation of surface colors as seen in this commit to fix this same issue https://github.com/jarnedemeulemeester/findroid/commit/0a1582f47b33147c6c797c76f674bdedad4a4909

Might try fixing this myself if no one gets around to it.

Edit: Seems like the above commit doesn't fix dynamic colors on samsung.