Filtered Chapters Show as Missing in Library

sgern commented 8 months ago

Steps to reproduce

Tap on a manga in your library.
Activate a filtering option that filters out some amount of chapters, but not the most recently released chapter.

Expected behavior

The chapters should just disappear from the chapter list with no further side effects.

Actual behavior

The chapter count displays "Missing X chapters", and the chapter list has several dividers labeled with "Missing X chapters", even if the source has no chapters missing.

Crash logs

No response

Mihon version

0.16.0

Android version

Android 13

Device

Google Pixel 3a XL

Other details

Any block of filtered chapters that reaches and includes the most recently released chapter does not add to the missing chapter count or cause a divider to be created.

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

mrphs7019 commented 5 months ago

same

mm12 commented 1 month ago

Is this really a bug? I find it quite useful when I am weeding out which duplicates to get rid of.

Animeboynz commented 1 month ago

Well I guess technically its not a bug but it would be better if it showed X chapters filtered instead of Missing X chapters 🤷‍♂️

mm12 commented 1 month ago

Well I guess technically its not a bug but it would be better if it showed X chapters filtered instead of Missing X chapters 🤷‍♂️

I would just change to wording to "missing or filtered", then. Separating them would make it crowded if you have both happening.. Though I could have sworn I have seen that wording before

BrutuZ commented 1 month ago

Are they missing from the current shown list? Yes, they are, so I see nothing wrong with it.

Animeboynz commented 1 month ago

Though I could have sworn I have seen that wording before

maybe here?

<plurals name="missing_chapters_warning">
    <item quantity="one">Skipping %d chapter, either the source is missing it or it has been filtered out</item>
    <item quantity="other">Skipping %d chapters, either the source is missing them or they have been filtered out</item>
</plurals>

Are they missing from the current shown list? Yes, they are, so I see nothing wrong with it.

Fair enough, I just hate seeing them every time I have downloaded only toggled. xD

mm12 commented 3 weeks ago

Though I could have sworn I have seen that wording before

maybe here?
<plurals name="missing_chapters_warning">
    <item quantity="one">Skipping %d chapter, either the source is missing it or it has been filtered out</item>
    <item quantity="other">Skipping %d chapters, either the source is missing them or they have been filtered out</item>
</plurals>
Are they missing from the current shown list? Yes, they are, so I see nothing wrong with it.

Fair enough, I just hate seeing them every time I have downloaded only toggled. xD

Honestly, for me, the ideal solution would be to just so a simple replace, not and not care that it looks weird. Example ({notes, not shown to user})

[chapter 55]
--N chapters filtered {filtered out 53-54}--
--N chapters missing {52 missing}--
--N chapters filtered {filtered out 51}--

mihonapp / mihon