Open JDKamalakar opened 9 months ago
Which theme is this? Sometimes a theme might have unfortunate colours in this situation since they're most often generated as a Material3 palette.
Dynamic theme.
Dynamic theme.
I'm pretty sure that just picks colours from your phone background or theme if I remember correctly. Nothing much Mihon could do in that situation. You could just pick a theme that has a better contrast ratio. Redesigning the badges would be a lot more work.
Dynamic theme.
I'm pretty sure that just picks colours from your phone background or theme if I remember correctly. Nothing much Mihon could do in that situation. You could just pick a theme that has a better contrast ratio. Redesigning the badges would be a lot more work.
Yes all other themes have distinct colors to better differentiate between them but, I am only talking about dynamic color theming, just because of how the badge looks in material you theming I have seen many people complaining (even in tachiyomi), that why asked for it plus adding curly edge on one of the side will make it stand out.
Counter-proposal: nuke dynamic theme ☢
Curly edge, as in, a differently shaped badge? Also, would this change only apply to the Dynamic Theme? Why make the UI inconsistent for one theme, the colours of which are not Mihon's fault?
If it applies to all themes, how would you make it work across the grid layout and the list layout? Because right now they look basically identical in both.
I think adding a suitable icon alongside the number could help with differentiating it. A "download" icon alongside the number of downloaded chapters and the "unread" icon for the unread chapters. Additionally, I think this can be applied across themes.
Icon space across all the themes. Something like this is just the download count badge side will be elevated above unread count. ( Sorry I don't have code & image of the badge it's in my computer & I don't have access to it, but from my experience it's quite easy.)
This wouldn't follow the material design standard the app is following. It'd be very odd to just have a squiggly thing just here
It's not consistent with the rest of the app
It's not consistent with the rest of the app
I don't think it will look inconsistent with the app.
Icon space across all the themes. Something like this is just the download count badge side will be elevated above unread count. ( Sorry I don't have code & image of the badge it's in my computer & I don't have access to it, but from my experience it's quite easy.)
I was imagining something like this instead.
Icon space across all the themes. Something like this is just the download count badge side will be elevated above unread count. ( Sorry I don't have code & image of the badge it's in my computer & I don't have access to it, but from my experience it's quite easy.)
I was imagining something like this instead.
It is not a bad idea but it will take lot more space so i dont think its a good option for android device
I have made a rough mock up of what it would look like on my android phone with a 6.5 inch screen. I don't think it takes up too much space especially since its towards the edge.
Let me know what yall think.
Icons, dents... No one suggesting simply splitting them to different corners of the cover. Unread counter on top-left corner (as current) and move Downloaded counter to top-right.
Though switching to a theme with a more distinctive palette like the default one would probably be more practical
Icons, dents... No one suggesting simply splitting them to different corners of the cover. Unread counter on top-left corner (as current) and move Downloaded counter to top-right.
Though switching to a theme with a more distinctive palette like the default one would probably be more practical
All of those moves around won't work in list view, where the badges both get placed at the end of a line anyway
Icons, dents... No one suggesting simply splitting them to different corners of the cover. Unread counter on top-left corner (as current) and move Downloaded counter to top-right.
Though switching to a theme with a more distinctive palette like the default one would probably be more practical
The top right corner already displays the language overlay and the continue reading button in the bottom right corner when they are enabled.
I am not sure where the local source overlay goes tho. I assume it would be in the bottom left since it's the only location left out.
All of those moves around won't work in list view, where the badges both get placed at the end of a line anyway
There's a list view? :clueless:
All of those moves around won't work in list view, where the badges both get placed at the end of a line anyway
There's a list view? :clueless:
Library Display settings list "Compact Grid", "Comfortable Grid", "Cover-only Grid", and "List"
In "List" view, entries are rows and covers and badges are relatively small
The top right corner already displays the language overlay and the continue reading button in the bottom right corner when they are enabled.
I am not sure where the local source overlay goes tho. I assume it would be in the bottom left since it's the only location left out.
Language and Resume wouldn't be confusing since they're not numbers. Local Source is a green folder icon on Top Right
Library Display settings list "Compact Grid", "Comfortable Grid", "Cover-only Grid", and "List" In "List" view, entries are rows and covers and badges are relatively small
It was a joke on the fact I only use the cover grid so end up forgetting other views exist
Nevertheless, all the more reason that switching to a theme with distinctive colors would be the easiest solution
I might create a pull request if I get my device repaired.
I have made a rough mock up of what it would look like on my android phone with a 6.5 inch screen. I don't think it takes up too much space especially since its towards the edge.
Let me know what yall think.
I feel like this solution will still work for all the library displays except for the List View. I feel like List View is the Ultra - Compact mode in which case losing the Icons could be seen as a necessary sacrifice for the sake of compactness.
Ideally we can figure out a way to integrate it with the List View.
I have made a rough mock up of what it would look like on my android phone with a 6.5 inch screen. I don't think it takes up too much space especially since its towards the edge.
Let me know what yall think.
This just feels like more clutter to me. I use 4 columns and that'll get more than half of my cover covered. The better options is to play with the theme's surface variants and whatnot so dynamic theme doesn't look dogshit.
Probably use inverse primary
I have made a rough mock up of what it would look like on my android phone with a 6.5 inch screen. I don't think it takes up too much space especially since its towards the edge. Let me know what yall think. Mockup
This just feels like more clutter to me. I use 4 columns and that'll get more than half of my cover covered. The better options is to play with the theme's surface variants and whatnot so dynamic theme doesn't look dogshit.
If you are using 4 columns, I can definitely see it becoming an issue. How about having it be a toggle to enable Icons?
That way it can serve as an accessibility feature for new users and users who may have colour blindness. You can leave it on by default since the default is the 2 columns. If you are a user willing to go through the settings to change to a 4 column or list view or some other display settings, you will probably see the Icon toggle and can make the decision based on your screen size.
Another option is to have a setting to hide either one of those. For example, I personally really don't care about download count on the library page, how many I've downloaded adds nothing to me, how many I need to read though does.
Might not solve for everyone but could help
Another option is to have a setting to hide either one of those. For example, I personally really don't care about download count on the library page, how many I've downloaded adds nothing to me, how many I need to read though does.
Might not solve for everyone but could help
Download badges are optional and in fact disabled by default.
Another option is to have a setting to hide either one of those. For example, I personally really don't care about download count on the library page, how many I've downloaded adds nothing to me, how many I need to read though does.
Might not solve for everyone but could help
Already a thing chief... Unread indicator title was removed because people kept wondering why their entries weren't updating, among other reasons
Another option is to have a setting to hide either one of those. For example, I personally really don't care about download count on the library page, how many I've downloaded adds nothing to me, how many I need to read though does. Might not solve for everyone but could help
Already a thing chief... Unread indicator title was removed because people kept wondering why their entries weren't updating, among other reasons
Oh damn that worked. Nice that solves my problems haha thanks.
No change to layout and better contrast with only one primary colour from material theme.
No change to layout and better contrast with only one primary colour from material theme.
It works.
No change to layout and better contrast with only one primary colour from material theme.
It works.
Yes
Describe your suggested feature
In current iteration unread count & download count looks almost exactly the same so it becomes hard to different if its download count or unread count.
Better way to differenceiate between them either give users option to select color for unread count or better make one of them have one of them black background & material UI color for number & also have curly line one of the side depending what it is.
Other details
No response
Acknowledgements