search

mihonapp / mihon

Free and open source manga reader for Android
Apache License 2.0
9.16k stars 402 forks source link

Text not showing up in search field #425

Open Splintorien opened 6 months ago

Splintorien commented 6 months ago

Steps to reproduce

When typing in the search text field to filter the manga, the text does not appear when typing from certain keyboards / devices

Expected behavior

Text appears

Actual behavior

Text does not appear

Crash logs

No response

Mihon version

0.16.3

Android version

See below

Device

See below

Other details

Acknowledgements

MajorTanya commented 6 months ago

What might be important to know is that the keyboards usually act like the input is actually working. Autocomplete/-correct all trigger and in most keyboards, it's possible to see the user's input in the autocomplete bar of the keyboard

Smol-Ame commented 6 months ago

Other Yandex keyboard user was using Huawei Mate 50 Pro, EMUI 13.0.0 (version 13.0.0.268(C10E10R2P1) )

Norsze commented 6 months ago

The tablet/fold is also a Huawei device with EMUI 13 they used SwiftKey, I recognize the gallery app icon.

molitar commented 6 months ago

+It's Google GBoard for voice typing. I have never seen GBoard not work in any app it even works in my banking app when I do a search for a specific transaction. So I am not sure what was changed in Mihon that it will not allow GBoard to allow voice to text. I have nerve tremors so I can typically type on them small keyboards I HAVE to rely on voice speech to text. You do not need to implement that you just need to figure out what changed in Mihon that is blocking a standard Android feature to not work.

The keyboard feature where you manually type works fine but NOT voice to text that is built into Android.

Smol-Ame commented 6 months ago

Other Yandex keyboard user was using Huawei Mate 50 Pro, EMUI 13.0.0 (version 13.0.0.268(C10E10R2P1) )

@Chertoved in the Discord posted earlier today, it seems they are able to write in the text field after pasting/autofilling whatever they typed into the text field (see video 1). They have to do this with evert new text field interaction it seems (see video 2)

https://github.com/mihonapp/mihon/assets/155411819/57c041b2-888f-4477-aac3-1c5f368c5822

https://github.com/mihonapp/mihon/assets/155411819/f4e920a7-71cd-48d8-8a64-fb3ecc32f757

molitar commented 6 months ago

Needs to be fixed basic default android feature should not be broken it worked until the new Mihon app than it broke something basic in Android.

theolm commented 6 months ago

Very weird bug. I managed to reproduce it (kind of) by changing the input to Russian with the Yandex keyboard and cycling the lifecycle of the app. After it comes back from the background I can't type it anymore. It happens with all the textfields in the application. I also test it with other applications (compose apps) and none of them have the same issue. I suspect it's something in the compose alpha libs that the app uses since the bug seems to be inside the BasicTextField (I can delete with a backspace but can't add new characters).

ps. It also happened with gboard text-to-speech

https://github.com/mihonapp/mihon/assets/9647399/16442619-df06-4386-b8c1-487db759f5c2

molitar commented 6 months ago

BasicTextField

theom, great find I aways end up changing focus to read a text message or see why update failed so it makes sense. Now hopefully they can fix it.

ChristianCiach commented 5 months ago

Same issue with my Huawai Matepad 11. Doesn't matter which keyboard app I am using; it happens with all of them.

theolm commented 5 months ago

I spent a few hours on this bug and was not able to find the root of the issue. I'm almost sure this is related to the alpha libs that the app uses. Why?

  1. I was not able to reproduce it in other compose applications (including compose multiplatform).
  2. During debugging I replaced the root of the application with a BOX with a default TextField inside and the bug still persists.
  3. It's also not a focus problem. I used talkback to confirm that the textfield focus is working as intended.

During the weekend I'll try to confirm if the problem is the foundation lib or if is something else.

Smol-Ame commented 1 month ago

For those with this typing issue, could you try out Mihon Beta r6776 to see if it works?

You don't need to swap apps (unless you want to), just install, go through setup really quick, and see if you can type in the search fields. A member in the Mihon Discord mentioned it worked for them with the current Beta version.

ChristianCiach commented 1 month ago

@Smol-Ame It works on my Huawai Matepad 11!

Finally, I am so happy! Thank you!