mihonapp / mihon

Free and open source manga reader for Android
Apache License 2.0
9.52k stars 422 forks source link

Crash in setup screen when using a controller/dpad/keyboard arrows #443

Open az4521 opened 7 months ago

az4521 commented 7 months ago

Steps to reproduce

  1. install mihon (blank data)
  2. open the app to the initial setup screen
  3. press any arrow key or dpad direction

Expected behavior

it should select/focus an item on the setup screen

Actual behavior

crashes with java.lang.IllegalStateException

Crash logs

mihon_crash_logs.txt

Mihon version

0.16.3

Android version

Android 11

Device

Cat S22 Flip

Other details

unrelated to this crash, but mihon has issues with dpad navigation in many other screens. the source browse screen for example, doesn't allow selecting manga. the chapter/manga details screen doesn't allow selecting chapters, only top bar items and the FAB. this isn't exactly an issue for phones, because the android CTS requires a touch screen, but this may cause usability issues on android tablets/2 in 1 laptops with keyboards, android TV, and consoles/set top boxes. that could maybe be a separate issue tagged as enhancement.

Acknowledgements

infyProductions commented 7 months ago

I'm a keyboard and mouse user of Mihon. On the reader, I can use the arrow keys to read manga (left and right directional buttons) or Manhwa (up and down directional). Anyways, I tried this on my WSA installation on my laptop, and it gave me the same crash when pressing any keys on the keyboard (E AndroidRuntime: java.lang.IllegalStateException: Cannot obtain node coordinator. Is the Modifier.Node attached?)

https://github.com/mihonapp/mihon/assets/31158494/717e64a0-2a34-4941-871a-d9ebc0871ec2

Device/Emulator used: Windows Subsystem for Android (2311.40000.5.0) OS version: Android 13

Crash log: mihon_crash_logs.txt