mihonapp / mihon

Free and open source manga reader for Android
Apache License 2.0
9.23k stars 406 forks source link

Incorrect tap location on Fire Tablets #70

Open RayW1986 opened 8 months ago

RayW1986 commented 8 months ago

Steps to reproduce

Use the app on a Fire tablet.

Expected behavior

Tapping the screen should register where you've actually tapped.

Actual behavior

This issue started with Tachiyomi 0.15.0, but since that update when using a Fire device, screen touches are not registering correctly. It's as though it's a touch behind? It's hard to explain so I have attached a video.

https://github.com/mihonapp/mihon/assets/7612076/171a5cdf-ca24-4e4e-a970-960ea5e73de1

You can see when I click downloaded its fine, but then when I click unread it toggles downloaded. It is like this throughout the app.

Crash logs

No response

Mihon version

0.16.0

Android version

Androidn11

Device

Fire Tablet Max 11 / Fire HD 10

Other details

No response

Acknowledgements

kazuhachuli commented 8 months ago

I have a problem that also started in Tachiyomi 0.15.0, mine is a little different, when you swipe back with gesture(right to left or left to right) to go at Home (Android Desktop) the animation doesn't work, It's like it closed in the blink of an eye.

david79111 commented 8 months ago

I have the same problem with incorrect touches on my fire hd 10 2023 android 11/latest fire os build

DannyFestor commented 8 months ago

I have the same issue with taps are one tap behind on the Kindle Fire HD 10 (13th Gen), Fire OS 8 (latest version). I think the first tap registers correctly, and then consecutive taps execute one tap late. On second tap, the first tap is executed again. On third tap, the second tap is executed, etc.

I also tried Mihon in an Android emulator with normal Android 14 and had no problems there, so I do not think this is a problem on tablets in general.

I don't know how to solve this, but I have the same phenomenon in 2 other apps:

I think this might be a tooling problem (Java/Kotlin version?) rather than a Mihon specific bug. I can't find anything on the internet concerning this problem except for this thread, really.

When looking through the update commit I found

Edit 2024/03/23: Proton Mail just updated their VPN app and introduced the same bug with the update. Up until now I had this bug only with side loaded apps (Mihon, Google Play, Proton Drive), but with Proton VPN there will finally be an app on the official Amazon store with the bug. The update passed through Google Play verification and is pushed on there, but not (yet?) on the Amazon store, I expect this is on part due to Amazon being slower, but also precisely because of this bug. Maybe Amazon will finally be made aware of the bug and fixes this on their end? I think it's only a matter of time until more and more apps on their store have this same bug now...

Edit 2024/04/12: I was wrong in my previous edit. The bugged Proton VPN app is now on the Amazon Web store...

sfai05 commented 7 months ago

Have the same issue on Fire Max 11 (13th Gen) with Fire OS 8.3.2.2

Wylie03 commented 5 months ago

I am currently having this issue on Fire HD 10 13th gen as well. Has anyone found a fix yet?

KevPantelakis commented 5 months ago

Same issue here with me Mihon and Google Play on a Fire HD 10 13th gen (2023)

doodleboink commented 3 months ago

I have the same issue. Fire Max 11. Enabling pointer location shows that it isn't an issue with the touch data, it's something to do with how that data is passed to certain apps.

DannyFestor commented 3 months ago

By the way, I don't have the bug in the preview version v6695 (previous) and v6697 (latest). Here's to hoping that whatever fixed it in the preview version gets quickly brought into stable.

(I have only tested these 2. No idea how long it is fixed over in the preview.)

kakai248 commented 3 months ago

I found this thread because I also hit this issue at work. Just to leave some more information here, this stopped happening on Compose 1.7.0 (alpha versions). Compose 1.5.4 and 1.6.7 exhibit the problem.

elfez commented 1 month ago

Can confirm this is resolved for me in Preview r6793. This is also on a Kindle Fire HD 10 (2023).