miicTeam / miic_R_package

Learning causal or non-causal graphical models using information theory
GNU General Public License v3.0
26 stars 3 forks source link

Incorrect choice of candidate conditioning node with zero score #100

Closed honghaoli42 closed 3 years ago

honghaoli42 commented 3 years ago

For a pair (X, Y), when choosing the candidate conditioning node Z with the highest score, multiple Zs can have the same score. The equality is resolved by comparing the mutual information sum I(X ; Z) + I(Y ; Z), see the patch 0914112. The patch incorrectly catches Zs with zero score, which is equal to the initial score without Z chosen (Only Zs with positive score should be considered as candidates). https://github.com/miicTeam/miic_R_package/blob/98826066ddd8b50e9da381f0c0e4de931fb9aa0e/src/get_information.cpp#L341-L349