miicTeam / miic_R_package

Learning causal or non-causal graphical models using information theory
GNU General Public License v3.0
26 stars 3 forks source link

Variable order in input file is not necessarily preserved in state order file #92

Closed honghaoli42 closed 3 years ago

honghaoli42 commented 3 years ago

Some functions/codes have assumed implicitly that the variable order in input file is preserved in state order file. This has led to the following known bugs:

  1. Erroneous partial correlation computation during post-processing. Fixed by 2a8f75c.
  2. Incorrect mark of contextual variables, as in https://github.com/miicTeam/miic_R_package/blob/2a8f75c8facbf1852e972b290e0f4722360b790c/R/miic.R#L443-L445