miickel / gulp-angular-templatecache

Concatenates and registers AngularJS templates in the $templateCache.
MIT License
525 stars 103 forks source link

Fix gulp-header version #125

Closed benjamincanac closed 8 years ago

matthieuauger commented 8 years ago

Thank you, in my case all my deployments were broken. @miickel Can we hope a quick merge ?

Until this is merged, you can fix it by specifying "gulp-header": "1.8.2" in your own package.json file.

andrewcurtis-mris commented 8 years ago

It doesn't seem like a good practice to leave the dependencies so loosely defined? Any one of these libraries could introduce an issue and it would get pulled in. Would it be better to more tightly define all of them rather than just the one that happened to break today? "event-stream": "3.x", "path": "0.x", "gulp-util": "3.x", "js-string-escape": "~1.0.0", "gulp-footer": "1.x", "gulp-header": "1.x", "gulp-concat": "2.x"

miickel commented 8 years ago

all versions in package.json are fixed with 1.8.1