miickel / gulp-angular-templatecache

Concatenates and registers AngularJS templates in the $templateCache.
MIT License
524 stars 103 forks source link

String escaping doesnt appear to work in v2.0.0 #131

Closed aarondh-zz closed 8 years ago

aarondh-zz commented 8 years ago

I'm getting the following in my templates file after upgrading to v2.0.0:

templateCache.put("/scripts/app/components/admin/admin.html","<nav class="navbar navbar-default navbar-fixed-top inverse">\r\n    ...</div>\r\n</footer>");

Note that the quotes are not being escaped correctly.

miickel commented 8 years ago

Hi! Unfortunately I do not have time to take a look at this atm. I would welcome any PR on this issue though.

ping @paulhhowells

paulhhowells commented 8 years ago

@miickel @aarondh I will take a look

paulhhowells commented 8 years ago

@aarondh please could you provide some code samples:

and I will try to reproduce your issue.

aarondh-zz commented 8 years ago

Looks like I was a little premature indicating a bug, the dev box in question did not have the latest node.js installed. Once upgraded everything is now parsing correctly

karan-kang commented 7 years ago

I am still experiencing this issue in version 2.0.0. Is this fixed?

paulhhowells commented 7 years ago

@Karankang007 please could you describe how to reproduce your issue, and provide some code samples:

karan-kang commented 7 years ago

Gulp code: https://gist.github.com/Karankang007/fb2ed6434a1509ef9df169069b344744 Source HTML: https://gist.github.com/Karankang007/83096fa4393fe75d96a6d2034f94d156 Geneted Output: https://gist.github.com/Karankang007/2062aa80234f8a5e04511fede263672b

NPM Version: 3.10.3 Gulp Version: 3.9.1